Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-165595

Guardian beam does not render when over a certain "Time" in level.dat

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • 23w03a
    • 19w40a, (60)
      19w46a, 1.15 Pre-release 4, 1.15 Pre-release 6, 1.15, 1.15.1, 1.15.1 Pre-release 1, 1.15.2 Pre-Release 1, 1.15.2 Pre-release 2, 1.15.2, 20w06a, 20w07a, 20w08a, 20w09a, 20w10a, 20w11a, 20w12a, 20w13a, 20w13b, 20w14a, 20w15a, 20w16a, 20w17a, 20w18a, 20w19a, 20w20a, 20w20b, 20w21a, 20w22a, 1.16 Pre-release 2, 1.16 Pre-release 3, 1.16 Pre-release 5, 1.16 Pre-release 6, 1.16 Pre-release 7, 1.16 Pre-release 8, 1.16 Release Candidate 1, 1.16, 1.16.1, 20w27a, 20w28a, 20w29a, 1.16.2 Pre-release 1, 1.16.2, 1.16.3, 1.16.4, 20w51a, 1.16.5, 21w08b, 21w11a, 21w14a, 1.17 Pre-release 2, 1.17 Pre-release 4, 1.17 Release Candidate 1, 1.17 Release Candidate 2, 1.17, 1.17.1 Pre-release 1, 1.17.1, 21w43a, 1.18.1, 1.18.2, 22w11a
    • Confirmed
    • Rendering
    • Normal

      The bug

      I was fighting with guardians and the fight is not how it was before - guardian beam rendering stopped working. Only bubbles render now.

      This happens when the game time reaches 2800000.

      Download the MC-165595 world attachment if you want to reproduce this.

      Code analysis

      Code analysis by entrigant can be found in this comment.
       

        1. 2019-11-14_14.06.01.png
          2019-11-14_14.06.01.png
          896 kB
        2. MC-165595.zip
          9.69 MB
        3. OLD.png
          OLD.png
          1.47 MB

          [MC-165595] Guardian beam does not render when over a certain "Time" in level.dat

          cocoraid added a comment -

          This bug is back using 1.19.3

          cocoraid added a comment - This bug is back using 1.19.3

          Connor Steppie added a comment -

          Relates to MC-1279 and MC-63720

          Connor Steppie added a comment - Relates to MC-1279 and MC-63720

          [Mod] ampolive added a comment - - edited

          As mentioned by entrigant, the reason this issue occurs is because of an integer overflow, caused by float to int conversions inside Mth.cos() and Mth.sin(). More specifically, it should overflow when the world time is above approximately 2745160 (might be slightly more or less than that), as that is the earliest number that would cause an overflow within GuardianRenderer#render(...):

          ...
float $$8 = (float)$$0.level.getGameTime() + $$2;
...
float $$18 = $$8 * 0.05f * -1.5f;
...
float $$31 = Mth.cos($$18 + 5.4977875f) * 0.282f;
...
GuardianRenderer.vertex($$46, $$48, $$49, $$31, $$41, $$32, $$20, $$21, $$22, 1.0f, $$50);
...

          [Mod] ampolive added a comment - - edited As mentioned by entrigant , the reason this issue occurs is because of an integer overflow, caused by float to int conversions inside Mth.cos() and Mth.sin() . More specifically, it should overflow when the world time is above approximately 2745160 (might be slightly more or less than that), as that is the earliest number that would cause an overflow within GuardianRenderer#render(...) : ... float $$8 = ( float )$$0.level.getGameTime() + $$2; ... float $$18 = $$8 * 0.05f * -1.5f; ... float $$31 = Mth.cos($$18 + 5.4977875f) * 0.282f; ... GuardianRenderer.vertex($$46, $$48, $$49, $$31, $$41, $$32, $$20, $$21, $$22, 1.0f, $$50); ...

          Gordon added a comment -

          The bug is still unresolved on 1.18.1. I encounter it on a self-owned private Minecraft Vanilla server. I have checked the "Time" in level.dat is 21396082, seems not only happen at power of two values.

          Gordon added a comment - The bug is still unresolved on 1.18.1. I encounter it on a self-owned private Minecraft Vanilla server. I have checked the "Time" in level.dat is 21396082, seems not only happen at power of two values.

          Connor Steppie added a comment -

          Is it 2800000 exactly? Or does it happen at a power of two value like 2097152?

          Connor Steppie added a comment - Is it 2800000 exactly? Or does it happen at a power of two value like 2097152?

          Tyson Cook added a comment -

          I just encounter this bug on my 1.17.1 server and sure enough the time is past 2800000.

          Tyson Cook added a comment - I just encounter this bug on my 1.17.1 server and sure enough the time is past 2800000.

          W_V added a comment -

          Thanks FireRainV for information, you are right. 

          I also attached a save where this occurs.

          W_V added a comment - Thanks FireRainV for information, you are right.  I also attached a save where this occurs.

          Francielly added a comment -

          Can confirm for 21w08b

          Francielly added a comment - Can confirm for 21w08b

          Michael Kreitzer added a comment -

          The fix for this is pretty easy, so easy I hope to see it implemented soon. The Guardian entity renderer alters the texture animation and other properties using the world tick time. Converting the world tick time to a float and using fractional render ticks causes overflows eventually.

          The solution is dead simple and initially done by AMereBagatelle in this PR for the Sodium mod: https://github.com/jellysquid3/sodium-fabric/pull/419

          It uses the current bounded day clock tick instead of the world tick. That is all.

          Thanks!

          Michael Kreitzer added a comment - The fix for this is pretty easy, so easy I hope to see it implemented soon. The Guardian entity renderer alters the texture animation and other properties using the world tick time. Converting the world tick time to a float and using fractional render ticks causes overflows eventually. The solution is dead simple and initially done by AMereBagatelle in this PR for the Sodium mod: https://github.com/jellysquid3/sodium-fabric/pull/419 It uses the current bounded day clock tick instead of the world tick. That is all. Thanks!

          Tomer Ben-David added a comment - - edited

          I found the bug cause:
          After creating backups upon backups, deleting files in those backups...
          When I tried to use NBTExplorer to modify the "Time" metadata in 'level.dat',
          I found out that when this value reaches ~2800000 or above , this issue occurs.
          Pasting this value or anything higher on a brand new world will have an 100% chance to cause this issue.

          Tomer Ben-David added a comment - - edited I found the bug cause: After creating backups upon backups, deleting files in those backups... When I tried to use NBTExplorer to modify the " Time " metadata in ' level.dat ', I found out that when this value reaches ~2800000 or above , this issue occurs. Pasting this value or anything higher on a brand new world will have an 100% chance to cause this issue.

            Fantastime [Mojang] Maxime Lebrot
            Vladimír W_V
            Votes:
            87 Vote for this issue
            Watchers:
            31 Start watching this issue

              Created:
              Updated:
              Resolved:
              CHK: