Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-210117

Sculk sensors don't detect ice/snow melting

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • 20w51a, (20)
      21w03a, 21w05b, 21w06a, 21w07a, 21w08b, 21w16a, 1.17, 21w38a, 21w42a, 1.18.1, 22w07a, 1.18.2, 22w14a, 22w18a, 1.19 Release Candidate 1, 1.19, 1.19.4, 23w17a, 1.20.1, 1.21.4
    • None
    • Confirmed
    • Game Events
    • Low
    • Gameplay

      The bug

      When ice/snow melts, sculk sensors nearby don't detect this, although it could be considered a vibration.

      How to reproduce

      1. Recreate the setup shown in setup.png
      2. Replace all diamond blocks in the setup with glowstone so that the ice begins to melt: 
        /fill ~9 ~-4 ~9 ~-9 ~9 ~-9 minecraft:glowstone replace minecraft:diamond_block

        When the ice melts, the sculk sensor is not activated

      Expected behavior

      The sculk sensor would be activated when the ice (or snow) melted.

      Code analysis

      Code analysis by Avoma can be found in this comment.

        1. MC-210117.mp4
          4.48 MB
        2. MC-210117.png
          MC-210117.png
          857 kB
        3. setup.png
          setup.png
          523 kB

          [MC-210117] Sculk sensors don't detect ice/snow melting

          [Mod] Avoma added a comment -

          Can confirm in 22w18a. Here's a code analysis regarding this issue.

          Code Analysis:

          The following is based on a decompiled version of Minecraft 1.18.2 using MCP-Reborn.

          net.minecraft.world.level.block.SnowLayerBlock.java
          public class SnowLayerBlock extends Block {
   ...
   public void randomTick(BlockState $bs, ServerLevel $sl, BlockPos $bp, Random $r) {
      if ($sl.getBrightness(LightLayer.BLOCK, $bp) > 11) {
         dropResources($bs, $sl, $bp);
         $sl.removeBlock($bp, false);
      }

   }
   ...
          net.minecraft.world.level.block.IceBlock.java
          public class IceBlock extends HalfTransparentBlock {
   ...
   protected void melt(BlockState $bs, Level $l, BlockPos $bp) {
      if ($l.dimensionType().ultraWarm()) {
         $l.removeBlock($bp, false);
      } else {
         $l.setBlockAndUpdate($bp, Blocks.WATER.defaultBlockState());
         $l.neighborChanged($bp, Blocks.WATER, $bp);
      }
   }
   ...

          If we look at the above classes, we can see that ice and snow melting simply aren't registered as game events as the gameEvent() method is never called, thus not detecting these actions as vibrations.

          Potential Fix:

          Simply calling the gameEvent() method where appropriate within this piece of code should resolve this problem. The "BLOCK_DESTROY" game event tag would be expected to be used here for both of these actions as ice/snow is removed from the world. The following line of code could be used in order to fix this:

          $LEVEL.gameEvent($PLAYER, GameEvent.BLOCK_DESTROY, $BLOCKPOS);

          [Mod] Avoma added a comment - Can confirm in 22w18a. Here's a code analysis regarding this issue. Code Analysis: The following is based on a decompiled version of Minecraft 1.18.2 using MCP-Reborn. net.minecraft.world.level.block.SnowLayerBlock.java public class SnowLayerBlock extends Block { ...   public void randomTick(BlockState $bs, ServerLevel $sl, BlockPos $bp, Random $r) { if ($sl.getBrightness(LightLayer.BLOCK, $bp) > 11) { dropResources($bs, $sl, $bp); $sl.removeBlock($bp, false ); } } ... net.minecraft.world.level.block.IceBlock.java public class IceBlock extends HalfTransparentBlock { ...   protected void melt(BlockState $bs, Level $l, BlockPos $bp) { if ($l.dimensionType().ultraWarm()) { $l.removeBlock($bp, false ); } else { $l.setBlockAndUpdate($bp, Blocks.WATER.defaultBlockState()); $l.neighborChanged($bp, Blocks.WATER, $bp); } } ... If we look at the above classes, we can see that ice and snow melting simply aren't registered as game events as the gameEvent() method is never called, thus not detecting these actions as vibrations. Potential Fix: Simply calling the  gameEvent() method where appropriate within this piece of code should resolve this problem. The "BLOCK_DESTROY" game event tag would be expected to be used here for both of these actions as ice/snow is removed from the world. The following line of code could be used in order to fix this: $LEVEL.gameEvent($PLAYER, GameEvent.BLOCK_DESTROY, $BLOCKPOS);

          [Mod] Avoma added a comment -

          Can confirm in 22w14a.

          [Mod] Avoma added a comment - Can confirm in 22w14a.

          [Mod] Avoma added a comment -

          Can confirm in 1.18.2.

          [Mod] Avoma added a comment - Can confirm in 1.18.2.

          AMGAMES04 added a comment - - edited

          can confirm in 22w07a

          AMGAMES04 added a comment - - edited can confirm in 22w07a

          [Mod] Avoma added a comment -

          Can confirm in 1.18.1.

          [Mod] Avoma added a comment - Can confirm in 1.18.1.

          [Mod] Avoma added a comment -

          Can confirm this behavior in 21w42a. Here are some extra details regarding this problem.

          The Bug:

          Sculk sensors are not activated upon ice or snow melting.

          Steps to Reproduce:

          • Build the setup as shown in the attachment below. setup.png
          • Replace all diamond blocks with glowstone so that the ice beings to melt.
          • /fill ~9 ~-4 ~9 ~-9 ~9 ~-9 minecraft:glowstone replace minecraft:diamond_block
          • Watch the ice closely and take note as to whether or not the sculk sensor activates upon ice melting.

          Observed Behavior:

          Sculk sensors are not activated upon ice or snow melting.

          Expected Behavior:

          Sculk sensors would be activated upon ice or snow melting.

          [Mod] Avoma added a comment - Can confirm this behavior in 21w42a. Here are some extra details regarding this problem. The Bug: Sculk sensors are not activated upon ice or snow melting. Steps to Reproduce: Build the setup as shown in the attachment below. setup.png Replace all diamond blocks with glowstone so that the ice beings to melt. /fill ~9 ~-4 ~9 ~-9 ~9 ~-9 minecraft:glowstone replace minecraft:diamond_block Watch the ice closely and take note as to whether or not the sculk sensor activates upon ice melting. Observed Behavior: Sculk sensors are not activated upon ice or snow melting. Expected Behavior: Sculk sensors would be activated upon ice or snow melting.

          [Mod] ampolive added a comment -

          Can confirm in 21w38a.

          [Mod] ampolive added a comment - Can confirm in 21w38a.

          [Mod] Avoma added a comment -

          Can confirm in 1.17.

          [Mod] Avoma added a comment - Can confirm in 1.17.

          [Mod] Avoma added a comment -

          Can confirm in 21w16a.

          [Mod] Avoma added a comment - Can confirm in 21w16a.

          [Mod] Avoma added a comment -

          Can confirm in 21w08b. Video attached.

          [Mod] Avoma added a comment - Can confirm in 21w08b. Video attached.

            Unassigned Unassigned
            violine1101 [Mod] violine1101
            Votes:
            14 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              CHK: