Uploaded image for project: 'Minecraft: Java Edition'
  1. Minecraft: Java Edition
  2. MC-259935

It can snow even when biome precipitation is set to NONE

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • None
    • 1.19.3, 1.21.1
    • None
    • Ubuntu 22.04, OpenJDK 17
    • Community Consensus
    • (Unassigned)

      If a place has temperature under 0.15, it can snow, even if the biome has precipitation set to "NONE".

      Steps to reproduce:
      1. Add a biome to an existing or new dimension that spawns in a place with temperature less than 0.15, and set the precipitation to NONE

      2. Wait for it to start raining

      3. Observer the snow

      Code analysis (Yarn mappings):
      In Biome#doesNotSnow(), it only checks the temperature, and not the precipitation field. To fix this, there would be something added to check if the temperature is >= 0.15 OR !precipitation
      Note: Some methods that rely on doesNotSnow will have side effects, like for example Biome#isCold. The old temperature check could be put there.

      This might have also caused the old "desert snow" bug that could be fixed by just changing the method and not tweaking biome settings to avoid buggy places (avoiding existing bugs instead of fixing them)

            Unassigned Unassigned
            PatrickMSM PatrickMSM
            Votes:
            5 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              CHK: