As we went from 1.20 to 1.21, the Datapack folder name changed.
Perhaps the change in the advancements folder to advancement has caused the newly added custom achievements as Datapack to not be achieved.